On Tue, Jan 14, 2020 at 04:26:18PM +0000, Joakim Tjernlund wrote: > Don't you need to "undo" ioremap, irq etc. in case of later errors? Better, convert to devm_
Attachment:
signature.asc
Description: PGP signature
Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe()
- From: Mark Brown <broonie@xxxxxxxxxx>
- Date: Tue, 14 Jan 2020 16:57:39 +0000
- Cc: "christophe.leroy@xxxxxx" <christophe.leroy@xxxxxx>, "linux-spi@xxxxxxxxxxxxxxx" <linux-spi@xxxxxxxxxxxxxxx>, "linuxppc-dev@xxxxxxxxxxxxxxxx" <linuxppc-dev@xxxxxxxxxxxxxxxx>, "devicetree@xxxxxxxxxxxxxxx" <devicetree@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "lkp@xxxxxxxxx" <lkp@xxxxxxxxx>, "geert@xxxxxxxxxxxxxx" <geert@xxxxxxxxxxxxxx>
- In-reply-to: <b6d01fa02e659db911df63a79d825080f03dfcb8.camel@infinera.com>
- References: <2a4a7e11b37cfa0558d68f0d35e90d6da858b059.1579017697.git.christophe.leroy@c-s.fr> <b6d01fa02e659db911df63a79d825080f03dfcb8.camel@infinera.com>
- User-agent: Mutt/1.10.1 (2018-07-13)
- References:
- [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe()
- From: Christophe Leroy
- Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe()
- From: Joakim Tjernlund
- [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe()
- Prev by Date: Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe()
- Next by Date: Re: [PATCH v3 1/7] dt-bindings: atmel-tcb: remove wildcard
- Previous by thread: Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe()
- Next by thread: [PATCH 0/2] SPI bus multiplexing
- Index(es):
 |