Re: [spi:for-next 1/2] drivers/spi/spi-fsl-spi.c:749: undefined reference to `of_irq_to_resource'

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Christophe,

On Tue, Dec 10, 2019 at 3:57 PM Christophe Leroy
<christophe.leroy@xxxxxx> wrote:
> Le 10/12/2019 à 11:46, Geert Uytterhoeven a écrit :
> > On Tue, Dec 10, 2019 at 9:10 AM kbuild test robot <lkp@xxxxxxxxx> wrote:
> >> It's probably a bug fix that unveils the link errors.
> >>
> >> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
> >> head:   d661a226ebf2961631a3961f2463f5db1b132430
> >> commit: 6f2e2fffd91fd9b4364fbefb78ebbe46d05b0bdd [1/2] Merge branch 'spi-5.5' into spi-linus
> >> config: sparc64-randconfig-a001-20191209 (attached as .config)
> >> compiler: sparc64-linux-gcc (GCC) 7.5.0
> >> reproduce:
> >>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >>          chmod +x ~/bin/make.cross
> >>          git checkout 6f2e2fffd91fd9b4364fbefb78ebbe46d05b0bdd
> >>          # save the attached .config to linux build tree
> >>          GCC_VERSION=7.5.0 make.cross ARCH=sparc64
> >>
> >> If you fix the issue, kindly add following tag
> >> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> >>
> >> All errors (new ones prefixed by >>):
> >>
> >>     drivers/spi/spi-fsl-spi.o: In function `of_fsl_spi_probe':
> >>>> drivers/spi/spi-fsl-spi.c:749: undefined reference to `of_irq_to_resource'
> >
> > config OF_IRQ
> >          def_bool y
> >          depends on !SPARC && IRQ_DOMAIN
> >
> >> vim +749 drivers/spi/spi-fsl-spi.c
> >
> > The driver should depend on OF_IRQ.
>
> Right. That's independent of the present patch though, as the fonction
> irq_of_parse_and_map() that's being replaced by of_irq_to_resource() is
> also depending on CONFIG_OF_IRQ.

That one does exist on SPARC, and has a dummy for !OF_IRQ:

include/linux/of_irq.h:
#if defined(CONFIG_OF_IRQ) || defined(CONFIG_SPARC)
/*
 * irq_of_parse_and_map() is used by all OF enabled platforms; but SPARC
 * implements it differently.  However, the prototype is the same for all,
 * so declare it here regardless of the CONFIG_OF_IRQ setting.
 */
extern unsigned int irq_of_parse_and_map(struct device_node *node, int index);

#else /* !CONFIG_OF && !CONFIG_SPARC */
static inline unsigned int irq_of_parse_and_map(struct device_node *dev,
                                                int index)
{
        return 0;
}
#endif /* !CONFIG_OF */

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds