Re: [PATCH 2/3] TI QSPI: support large flash devices

[Vignesh Raghavendra <vigneshr@xxxxxx>]

On 06/12/19 9:30 pm, Jean Pihet wrote:
> The TI QSPI IP has limitations:
> - the MMIO region is 64MB in size
> - in non-MMIO mode, the transfer can handle 4096 words max.
> 
> Add support for bigger devices.
> Use MMIO and DMA transfers below the 64MB boundary, use
> software generated transfers above.

Could you change the $subject prefix to be "spi: spi-ti-qspi:"


[...]

> -574,6 +601,7 @@ static int ti_qspi_exec_mem_op(struct spi_mem *mem,
>  
>  static const struct spi_controller_mem_ops ti_qspi_mem_ops = {
>  	.exec_op = ti_qspi_exec_mem_op,
> +	.adjust_op_size = ti_qspi_adjust_op_size,
>  };
>  
>  static int ti_qspi_start_transfer_one(struct spi_master *master,
> @@ -599,12 +627,11 @@ static int ti_qspi_start_transfer_one(struct spi_master *master,
>  	frame_len_words = 0;
>  	list_for_each_entry(t, &m->transfers, transfer_list)
>  		frame_len_words += t->len / (t->bits_per_word >> 3);
> -	frame_len_words = min_t(unsigned int, frame_len_words, QSPI_FRAME);
>  
>  	/* setup command reg */
>  	qspi->cmd = 0;
>  	qspi->cmd |= QSPI_EN_CS(spi->chip_select);
> -	qspi->cmd |= QSPI_FLEN(frame_len_words);
> +	qspi->cmd |= QSPI_FLEN(QSPI_FRAME);
>  

Hmm, change itself is harmless. But what is the motivation behind the
change?

>  	ti_qspi_write(qspi, qspi->dc, QSPI_SPI_DC_REG);
>  
> 

-- 
Regards
Vignesh