Re: Side effect of SPI GPIO descriptor usage

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Dec 4, 2019 at 4:47 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Tue, Dec 3, 2019 at 5:35 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
> > On Mon, Dec 02, 2019 at 02:11:51PM +0000, Phil Elwell wrote:


> and I can find one more outlier:
>
> drivers/mmc/host/mmc_spi.c, function mmc_spi_initsequence()
>
> This very clearly want the inverse polarity of whatever was the default,
> but the code assumes that SPI_CS_HIGH implies that this is the
> actual physical level and forces it high, then low. I will send
> a patch for this: what they want to achieve is the inverse of
> whatever was configured.

Linus, hold on.
MMC SPI is abusing protocol, you can't fix it in logical way.
I recommend to read the protocol specification.

P.S. I would be glad to be wrong, though.

-- 
With Best Regards,
Andy Shevchenko