On Tue, Dec 03, 2019 at 07:28:18PM +0100, Geert Uytterhoeven wrote:
> On Tue, Dec 3, 2019 at 4:46 AM Chris Brandt <chris.brandt@xxxxxxxxxxx> wrote:
> > +static const struct of_device_id of_spibsc_match[] = {
> > + { .compatible = "renesas,spibsc"},
> > + { .compatible = "renesas,r7s72100-spibsc", .data = (void *)HAS_SPBCR},
> > + { .compatible = "renesas,r7s9210-spibsc"},
> Do you need to match against all 3 in the driver?
> Does SPIBSC work on RZ/A1 when not setting HAS_SPBCR?
> If not, the fallback to "renesas,spibsc" is not valid for RZ/A1.
I do think it's useful to explicitly list all the compatibles in
the driver, it documents the handling needed for each of the
variants and it provides some robustness against DTs that neglect
to list the fallback compatibles.
Attachment:
signature.asc
Description: PGP signature
