Re: Boot failure with 5.4-rc5, bisected to 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO descriptors")

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Nov 27, 2019 at 2:54 PM Christophe Leroy
<christophe.leroy@xxxxxx> wrote:
> Le 27/11/2019 à 14:52, Linus Walleij a écrit :
> > On Wed, Nov 27, 2019 at 2:45 PM Christophe Leroy
> > <christophe.leroy@xxxxxx> wrote:
> >> Le 27/11/2019 à 14:00, Linus Walleij a écrit :
> >
> >>> Try to remove the "spi-cs-high" bool flag from your nodes,
> >>> because it seems like the old code was ignoring them.
> >>>
> >>> Does that solve the problem?
> >>
> >> Yes it does. Many thanks. I let you manage the packaging of fixes.
> >
> > OK I will send a final batch of 3 patches fixing this.
> >
> > Do you have these old device trees deployed so that we
> > also need to make sure that old device trees that have this
> > ambigous syntax will force precendence for the flag on the
> > GPIO line if both are specified for the "fsl,spi" instances?
> >
>
> No, we deliver device trees together with Linux kernel (embedded in an
> Uboot ITS/ITB image) so no worry on old device trees.

OK thanks!

I sent three patches, can you apply them on a clean tree
and confirm it solves the problem (fingers crossed...)

Thanks a lot for helping me fix this!

Yours,
Linus Walleij