On Tue, Oct 22, 2019 at 12:29:01PM +0200, Alvaro Gamez Machado wrote: > On Tue, Oct 22, 2019 at 11:20:07AM +0100, Mark Brown wrote: > > Any new DT property needs documentation adding but in any case this > Oh, ok. If this patch is of any interest, then I should provide changes to > the appropriate file under Documentation/, is that right? Yes. > I was preparing and testing a second patch to add "spi-bits-per-word" > property to children of the SPI driver, similar to the spi-max-frequency > property and others alike, to fully support AXI Quad SPI core with different > word widths. This also modifies the DT, so I guess it'd be better to send a > single patch that comprises all these changes alongside the DT > documentation. Would that be correct procedure? Usually the DT changes should be a separate patch to the code changes. > > shouldn't be set in DT, it should be set by the client driver - it's > > going to be a fixed property of the device, not something that varies > > per system. > But this is in fact something that changes per system. When instantiating an > AXI Quad SPI core in a HDL design that's exactly one of the options you can > provide. In fact, in the board I'm working with right now, I'm instantiating > two SPI cores, one of them with 8 bits per word but the other one requires > 32 bits per word, as the devices it's going to talk to have this > requirement. This is still something that should be configured by the client driver, if you send data with a different word size to that the client intends it'll just get corrupted.
Attachment:
signature.asc
Description: PGP signature
