Re: [PATCH 1/2] spi: omap-100k: Remove set but not used variable 'dataH'

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Zhengbin,

On Tue, Oct 8, 2019 at 10:25 AM zhengbin <zhengbin13@xxxxxxxxxx> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/spi/spi-omap-100k.c: In function spi100k_read_data:
> drivers/spi/spi-omap-100k.c:140:6: warning: variable dataH set but not used [-Wunused-but-set-variable]
>
> It is not used since commit 35c9049b2704 ("Add OMAP spi100k driver")
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: zhengbin <zhengbin13@xxxxxxxxxx>

Have you tested this on actual hardware?
Are you sure the hardware does not require reading this register to work
properly?

> --- a/drivers/spi/spi-omap-100k.c
> +++ b/drivers/spi/spi-omap-100k.c
> @@ -128,7 +128,7 @@ static void spi100k_write_data(struct spi_master *master, int len, int data)
>
>  static int spi100k_read_data(struct spi_master *master, int len)
>  {
> -       int dataH, dataL;
> +       int dataL;
>         struct omap1_spi100k *spi100k = spi_master_get_devdata(master);
>
>         /* Always do at least 16 bits */
> @@ -146,7 +146,6 @@ static int spi100k_read_data(struct spi_master *master, int len)
>         udelay(1000);
>
>         dataL = readw(spi100k->base + SPI_RX_LSB);
> -       dataH = readw(spi100k->base + SPI_RX_MSB);
>         spi100k_disable_clock(master);
>
>         return dataL;

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds