Re: [PATCH spi for-5.4 13/14] spi: spi-fsl-dspi: Reduce indentation level in dspi_interrupt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH spi for-5.4 13/14] spi: spi-fsl-dspi: Reduce indentation level in dspi_interrupt
From: Mark Brown <broonie@xxxxxxxxxx>
Date: Wed, 21 Aug 2019 11:01:39 +0100
Cc: linux-spi@xxxxxxxxxxxxxxx
In-reply-to: <CA+h21hoYv=a5qm4ewB7ey2K2N5Uv5Wm9G2fELX_0ukJZcdXbQQ@mail.gmail.com>
References: <20190818180115.31114-1-olteanv@gmail.com> <20190818180115.31114-14-olteanv@gmail.com> <20190820130257.GD4738@sirena.co.uk> <CA+h21hqCyJ4WQgP31gcMq21k6wG8YQmbg0BZKwh_2YKvWKY5RA@mail.gmail.com> <CA+h21hoYv=a5qm4ewB7ey2K2N5Uv5Wm9G2fELX_0ukJZcdXbQQ@mail.gmail.com>
User-agent: Mutt/1.10.1 (2018-07-13)

On Wed, Aug 21, 2019 at 01:49:15AM +0300, Vladimir Oltean wrote:

> But shouldn't it be returning IRQ_NONE in that case? Right now it's
> returning IRQ_HANDLED.

Yes, that's a bug that should be fixed.

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH spi for-5.4 00/14] NXP DSPI driver cleanup
  - From: Vladimir Oltean
- [PATCH spi for-5.4 13/14] spi: spi-fsl-dspi: Reduce indentation level in dspi_interrupt
  - From: Vladimir Oltean
- Re: [PATCH spi for-5.4 13/14] spi: spi-fsl-dspi: Reduce indentation level in dspi_interrupt
  - From: Mark Brown
- Re: [PATCH spi for-5.4 13/14] spi: spi-fsl-dspi: Reduce indentation level in dspi_interrupt
  - From: Vladimir Oltean
- Re: [PATCH spi for-5.4 13/14] spi: spi-fsl-dspi: Reduce indentation level in dspi_interrupt
  - From: Vladimir Oltean

Prev by Date: Re: [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver
Next by Date: Re: [PATCH spi for-5.4 1/5] spi: Use an abbreviated pointer to ctlr->cur_msg in __spi_pump_messages
Previous by thread: Re: [PATCH spi for-5.4 13/14] spi: spi-fsl-dspi: Reduce indentation level in dspi_interrupt
Next by thread: [PATCH spi for-5.4 14/14] spi: spi-fsl-dspi: Remove impossible to reach error check
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [Linux for Samsung SOC] [eCos] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [Linux MIPS] [Yosemite Campsites]