On Fri, Aug 16, 2019 at 03:37:46PM +0300, Vladimir Oltean wrote: > On Fri, 16 Aug 2019 at 15:21, Mark Brown <broonie@xxxxxxxxxx> wrote: > > This is difficult to review since there's a bunch of largely unrelated > > changes all munged into one patch. It'd be better to split this up so > > each change makes one kind of fix, and better to do this separately to > > the rest of the series. In particular having alignment changes along > > with other changes hurts reviewability as it's less immediately clear > > what's a like for liken substitution. > Yes, the diff of this patch looks relatively bad. But I don't know if > splitting it in more patches isn't in fact going to pollute the git > history, so I can just as well drop it. No problem with lots of patches in git history if you want to split it up (and probably split it out of the series). Like I say it's mainly the alignment changes that it'd be better to pull out, the others really should be but it's easier to cope there.
Attachment:
signature.asc
Description: PGP signature
