Re: [PATCH v2 2/2] spi: npcm-fiu: add NPCM FIU controller driver

[Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>]

On Thu,  8 Aug 2019 16:14:48 +0300
Tomer Maimon <tmaimon77@xxxxxxxxx> wrote:


> +
> +static const struct spi_controller_mem_ops npcm_fiu_mem_ops = {
> +	.exec_op = npcm_fiu_exec_op,

No npcm_supports_op()? That's suspicious, especially after looking at
the npcm_fiu_exec_op() (and the functions called from there) where the
requested ->buswidth seems to be completely ignored...

> +	.dirmap_create = npcm_fiu_dirmap_create,
> +	.dirmap_read = npcm_fiu_direct_read,
> +	.dirmap_write = npcm_fiu_direct_write,
> +};
> +