Re: [PATCH] spi/acpi: fix incorrect ACPI parent check

Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> · Thu, 20 Jun 2019 15:21:02 +0300

On 6/20/19 1:33 PM, Ard Biesheuvel wrote:
Jarkko, does this help?

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 50d230b33c42..d072efdd65ba 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1914,6 +1914,7 @@ static acpi_status
acpi_register_spi_device(struct spi_controller *ctlr,
                 return AE_OK;

         lookup.ctlr             = ctlr;
+       lookup.max_speed_hz     = 0;
         lookup.mode             = 0;
         lookup.bits_per_word    = 0;
         lookup.irq              = -1;

Yes it does.

I guess you have some cleanups or changes on top of your b5e3cf410b48 
("spi/acpi: fix incorrect ACPI parent check") since for me change go 
around lines @@ -1981,6 +1981,7 @@ ?

--
Jarkko






