Re: [PATCH RFC 2/2] mfd: add Renesas RPC-IF driver

[masonccyang@xxxxxxxxxxx]

Hi Jones, 

> > 
> > > Looks like a flash device to me.
> > 
> >    More like a multi-protocol flash controller, with the real flash 
chip connected
> > to it.
> 
> Right, this has been my point from the start.
> 
> It's a flash controller.  Sure, you can access it in different ways,
> but it's still *just* a flash controller and thus not a true MFD.
> 
> Surely this whole thing, including the shared portion should live in
> one of the memory related subsystems?
> 
> This is not the first device people have tried to shove in MFD, that
> is really *just* an <X> device, able to be controlled via different
> protocols.
> 
> MFD is for registering child devices of chips which offer genuine
> cross-subsystem functionality.  It is not designed for mode selecting,
> or as a place to shove shared code just because a better location
> doesn't appear to exist.
> 
> Also, ramming it into drivers/platform/<vendor> is not correct either,
> since this is not a platform controller driver either.


I will patch RPC-IF back to SPI only and 
rebase onto previous patches as bellow:

> "Mark Brown" <broonie@xxxxxxxxxx> 
> 2019/02/12 下午 10:22
> 
> To
> 
> "Mason Yang" <masonccyang@xxxxxxxxxxx>, 
> 
> cc
> 
> "Sergei Shtylyov" <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>, "Mark Brown" 
> <broonie@xxxxxxxxxx>, broonie@xxxxxxxxxx, marek.vasut@xxxxxxxxx, linux-
> kernel@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, 
bbrezillon@xxxxxxxxxx, 
> linux-renesas-soc@xxxxxxxxxxxxxxx, "Geert Uytterhoeven" <geert
> +renesas@xxxxxxxxx>, sergei.shtylyov@xxxxxxxxxxxxxxxxxx, 
juliensu@xxxxxxxxxxx,
> "Simon Horman" <horms@xxxxxxxxxxxx>, zhengxunli@xxxxxxxxxxx, 
linux-spi@xxxxxxxxxxxxxxx
> 
> Subject
> 
> Applied "spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver" to 
the spi tree
> 
> The patch
> 
>    spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver
> 
> has been applied to the spi tree at
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 
> 
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted. 

thanks & best regards,
Mason


CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information 
and/or personal data, which is protected by applicable laws. Please be 
reminded that duplication, disclosure, distribution, or use of this e-mail 
(and/or its attachments) or any part thereof is prohibited. If you receive 
this e-mail in error, please notify us immediately and delete this mail as 
well as its attachment(s) from your system. In addition, please be 
informed that collection, processing, and/or use of personal data is 
prohibited unless expressly permitted by personal data protection laws. 
Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================



============================================================================

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================