Re: [PATCH] spi: Kconfig: spi-synquacer: Added ARM and ARM64 dependence

[Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>]

On Mon, 17 Jun 2019 at 12:17, Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Mon, Jun 17, 2019 at 03:09:57PM +0900, Masahisa Kojima wrote:
> > kbuild test reported that Alpha and some of the architectures
> > are missing readsx/writesx functions.
> > spi-synquacer driver is only targeted for arm and arm64 platforms.
> > With that, added ARM and ARM64 dependence in Kconfig.
>
> Are you sure it's those functions (which only appear to be defined on
> arc according to a quick grep) and are you sure that there's no other
> Kconfig symbol specifically for those being defined which can be used
> rather than depending on specific architectures?
>

I'm not sure I see the point of this. Building this driver for alpha
and parisc has no use in practice, and does not provide any additional
build coverage given that the driver can be enabled on any ARMA/ARM64
build.

> > This patch also specifies the default compile type as module.
>
> This should be a separate patch and we don't generally change the
> default unless there's a reason to do so.'

That was my suggestion - just 'default m' is generally not accepted,
but 'default m' for a driver if you enabled the ARCH_xxxx in question
is reasonable, no?