Re: [PATCH] spidev: Use dev_dbg() instead of pr_debug()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 04, 2019 at 09:22:30AM +0200, Geert Uytterhoeven wrote:
> On Tue, Jun 4, 2019 at 4:53 AM Fabio Estevam <festevam@xxxxxxxxx> wrote:

> >         if (status) {
> > -               pr_debug("spidev: nothing for minor %d\n", iminor(inode));
> > +               dev_dbg(&spidev->spi->dev, "spidev: nothing for minor %d\n",
> > +                       iminor(inode));

> This doesn't look correct to me, as a non-zero status indicates that the
> corresponding spidev was not found, and thus spidev is not a valid
> object pointer to dereference.

Right, the issue is that we don't have the device.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux