On Mon, Apr 15, 2019 at 02:30:30PM -0700, Sowjanya Komatineni wrote: > This patch exports spi_set_cs of the spi core to allow SPI masters > to use when gpio based chip select is needed. This isn't really what I meant when I said it'd be good to use the core GPIO code - this function doesn't do a huge amount really and the usage of it in your subsequent patch for the driver isn't exactly joined up with the little it does (which is mainly swapping in the GPIO chip select instead of the hardware chip select) isn't used in your driver usage of this as far as I can see. The bulk of the chip select handling code in the core is actually in transfer_one_message() which your driver doesn't use as it's got it's own implementation of that; I've not looked in enough detail to figure out if it could use it.
Attachment:
signature.asc
Description: PGP signature
