On 04/15/2019 10:37 AM, Mason Yang wrote: > Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. > > Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> This patch looked good to me (you seem to have incorporated another patch of mine here :-)). Since the patch is already carrying my signoff, I wouldn't add a Reviewed-by: tag. However, I believe that all manipulations with the RPC-IF hardware need to be moved to the MFD driver, to be called from the SPI and HF subdrivers... doesn't seem an easy task though... MBR, Sergei