RE: [PATCH 1/1] spi: pxa2xx: add driver enabling message

[Flavio Suligoi <f.suligoi@xxxxxxx>]

Hi Jarkko,

> Hi
> 
> On 4/8/19 6:22 PM, Flavio Suligoi wrote:
> > Add an info message for the PXA2xx device driver start-up,
> > with the indication of the transfer mode used (DMA or GPIO).
> >
> > This info is useful to individuate the timing when
> > the module starts.
> >
> > Signed-off-by: Flavio Suligoi <f.suligoi@xxxxxxx>
> > ---
> >   drivers/spi/spi-pxa2xx.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
> > index f7068cc..d449501 100644
> > --- a/drivers/spi/spi-pxa2xx.c
> > +++ b/drivers/spi/spi-pxa2xx.c
> > @@ -1826,6 +1826,9 @@ static int pxa2xx_spi_probe(struct platform_device
> *pdev)
> >   		goto out_error_clock_enabled;
> >   	}
> >
> > +	dev_info(dev, "PXA2xx SPI master controller (%s mode)\n",
> > +		 platform_info->enable_dma ? "DMA" : "PIO");
> > +
> >   	return status;
> >
> Would this look better if moved before devm_spi_register_controller()
> call?

Ok, so in case of SPI registering failure, we have two messages, as:

pxa2xx-spi 80860F0E:00: PXA2xx SPI master controller (DMA mode)
pxa2xx-spi 80860F0E:00: problem registering spi controller

Do you think that it is more explicative?

Flavio