Re: [PATCH V3 0/9] spi: bcm2835aux: bug fixes and improvements

[Stefan Wahren <stefan.wahren@xxxxxxxx>]

> kernel@xxxxxxxxxxxxxxxx hat am 30. März 2019 um 10:30 geschrieben:
> 
> 
> From: Martin Sperl <kernel@xxxxxxxxxxxxxxxx>
> 
> Set of patches improving the spi-bcm2835aux driver and fixing
> a data read corruption bug.
> 
> The main motivation is a rare data corruption fix that is mostly
> observed in polling mode first reported by Hubert Denkmair.
> 
> So this patchset first implements a means to control the parameters
> of when polling mode is used via module parameters and exports
> the corresponding statistics.
> 
> As stated in original patch the driver does not support native CS.
> But when cs-gpios is not configured in the dt (so a buggy dt) it is
> still working with a lot of limitations, but the driver does not report
> this fact.
> 
> So this patchset adds reporting and allows for a single native CS
> (with limited functionality) to continue working with a buggy DT.
> One question here remains: do we need to legacy support DTs
> that are not following specs in the first place?
> 
> Then there is the real fix for the data-corruption which is split
> into 3 parts: some code cleanup with code reuse, removing "dangerous"
> fifo read (possibly introducing fifo data corruption) and safe fifo read.
> 
> Also we remove some dead code.
> 
> ---
> Changelog:
>   V1 -> V2: reordering commits as per request of Stefan Wahren
>             to help backporting the "essential" bugfixes go in first
> 	    remove the dependency on a different patchset focused on
> 	    making cs_change delay configurable
>   V2 -> V3: incorporated feedback by Stefan Wahren

The whole series is:

Acked-by: Stefan Wahren <stefan.wahren@xxxxxxxx>

Thanks