Re: [PATCH v8 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

[Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>]

On 03/25/2019 10:12 PM, Sergei Shtylyov wrote:

>>>> +static void rpc_spi_mem_set_prep_op_cfg(struct spi_device *spi,
>>>> +               const struct spi_mem_op *op,
>>>> +               u64 *offs, size_t *len)
>>>> +{
>>>> +   struct rpc_spi *rpc = spi_controller_get_devdata(spi->controller);
>>>
>>>> +   if (op->dummy.nbytes) {
>>>> +      rpc->smenr |= RPC_SMENR_DME;
>>>> +      rpc->dummy = RPC_SMDMCR_DMCYC(op->dummy.nbytes);
>>>
>>>    SMDMCR.DMCYC is in bits -- you forgot to multiply by 8.
>>
>> ?
>>
>> It's dummy cycles setting, i.e,. 0 is 1 cycle dummy and
> 
>    Yeah, I should've written "cycles", sorry about that.

   I also should've mentioned that w/o this change the "read SFDP" command
returns garbage and the flash doesn't work.

[...]

MBR, Sergei