Re: [PATCH] spi: sh-msiof: Add reset of registers before starting transfer

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Wolfram,

On Fri, Mar 1, 2019 at 12:43 PM Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> > +     for (k = 100; k > 0; k--) {
> > +             if (!(sh_msiof_read(p, CTR) & mask))
> > +                     break;
> > +
> > +             udelay(1);
> > +     }
>
> Why no reuse of sh_msiof_modify_ctr_wait? And can't we maybe even use
> readl_poll_timeout() here since we know the register is fixed to CTR?

Thanks, that looks like a good improvement. Will do.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds