Re: [PATCH 1/3] spi: bcm2835: add driver stats to debugfs

[Lukas Wunner <lukas@xxxxxxxxx>]

On Sun, Feb 24, 2019 at 04:23:09PM +0000, kernel@xxxxxxxxxxxxxxxx wrote:
> @@ -111,8 +112,60 @@ struct bcm2835_spi {
>  	int rx_prologue;
>  	unsigned int tx_spillover;
>  	unsigned int dma_pending;
> +
> +#if defined(CONFIG_DEBUG_FS)
> +#define BCM2835_AUX_INCR(field) ((field)++)
> +	u64 count_transfer_polling;
> +	u64 count_transfer_irq;
> +	u64 count_transfer_irq_after_poll;
> +	u64 count_transfer_dma;
> +
> +	struct dentry *debugfs_dir;

Please also amend the kerneldoc of struct bcm2835_spi.


> +#define BCM2835_AUX_INCR(field)
                   ^^^

Why aux?  This is the non-aux driver.


> +	/* the base directory */
> +	dir = debugfs_create_dir(name, NULL);

Missing error handling.

Thanks,

Lukas