Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 01 2019, Mark Brown wrote:

> On Fri, Feb 01, 2019 at 11:17:07AM +0100, Stefan Roese wrote:
>
>> @@ -1,3 +1,4 @@
>> +// SPDX-License-Identifier: GPL-2.0
>>  /*
>>   * spi-mt7621.c -- MediaTek MT7621 SPI controller driver
>>   *
>
> Please convert the entire comment into a C++ comment so it looks more
> intentional.

Hi Mark,
 I don't understand what you mean by this, or possibly I do understand
 and strongly disagree.

 It is extremely common in the kernel for a file to start
   // SPDX-License-Identifier.....

 and to have that immediately followed by a comment lile:

 /*
  * .....
  * ....


 This patch makes this file match much of the rest of the kernel.  Why
 do you want something different?

Thanks,
NeilBrown

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux