RE: [PATCH v6 0/7] spi: add support for octal mode

[Yogesh Narayan Gaur <yogeshnarayan.gaur@xxxxxxx>]

Hi Vignesh,

> -----Original Message-----
> From: Vignesh R [mailto:vigneshr@xxxxxx]
> Sent: Wednesday, December 19, 2018 6:14 PM
> To: Yogesh Narayan Gaur <yogeshnarayan.gaur@xxxxxxx>; linux-
> mtd@xxxxxxxxxxxxxxxxxxx; boris.brezillon@xxxxxxxxxxx; broonie@xxxxxxxxxx;
> marek.vasut@xxxxxxxxx; linux-spi@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx
> Cc: tudor.ambarus@xxxxxxxxxxxxx; robh@xxxxxxxxxx; mark.rutland@xxxxxxx;
> shawnguo@xxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> computersforpeace@xxxxxxxxx; frieder.schrempf@xxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v6 0/7] spi: add support for octal mode
> 
> Hi,
> 
> On 19/12/18 3:41 PM, Yogesh Narayan Gaur wrote:
> > Add support for octal mode IO data transfer.
> > Micron flash, mt35xu512aba, supports octal mode data transfer and NXP
> > FlexSPI controller supports 8 data lines for data transfer (Rx/Tx).
> >
> > Patch series
> > * Add support for octal mode flags and parsing of same in spi driver.
> > * Add parsing logic for spi-mem framework and m25p80.c device file.
> > * Add opcodes for octal I/O commands in spi-nor framework, Read and Write
> proto for (1-1-8/1-8-8) mode.
> >   Opcodes are added as per octal data IO commands required for
> mt35xu512aba [1] flash.
> > * Add mode bit required for octal mode in nxp-fspi driver [2].
> > * Define binding property 'spi-rx/tx-bus-width' for LX2160ARDB target [2].
> >
> > Tested on LX2160ARDB target with nxp-fspi driver, below are Read
> > performance number of 1-1-1 and 1-1-8 read protocol.
> >
> >  root@lxxx:~# cat /proc/mtd
> >  dev:    size   erasesize  name
> >  mtd0: 04000000 00001000 "spi0.0"
> >  mtd1: 04000000 00001000 "spi0.1"
> >  root@lxxx:~# time mtd_debug read /dev/mtd0 0x0 0x1000000 0read
> > Copied 16777216 bytes from address 0x00000000 in flash to 0read
> >
> >  real    0m2.792s
> >  user    0m0.000s
> >  sys     0m2.790s
> >  root@lxxx:~# time mtd_debug read /dev/mtd1 0x0 0x1000000 0read
> > Copied 16777216 bytes from address 0x00000000 in flash to 0read
> >
> >  real    0m0.441s
> >  user    0m0.000s
> >  sys     0m0.440s
> >  root@ls1012ardb:~#
> >
> >
> >  Flash device MTD0 configured in 1-1-1 protocol.
> >  Flash device MTD1 configured in 1-1-8 protocol.
> >
> > [1]
> > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
> > chwork.ozlabs.org%2Fproject%2Flinux-
> mtd%2Flist%2F%3Fseries%3D70384%26s
> >
> tate%3D*&amp;data=02%7C01%7Cyogeshnarayan.gaur%40nxp.com%7Cac5c9
> ca4ad0
> >
> 84f10762208d665af9130%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C636
> >
> 808202064181032&amp;sdata=LCjo%2B%2FhIpEYygsLHMFzb65ZtXjsDdhEAVV4
> %2BjQ
> > iyUtI%3D&amp;reserved=0 [2]
> > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
> > chwork.ozlabs.org%2Fproject%2Flinux-
> mtd%2Flist%2F%3Fseries%3D76402&amp
> > ;data=02%7C01%7Cyogeshnarayan.gaur%40nxp.com%7Cac5c9ca4ad084f107
> 62208d
> >
> 665af9130%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636808202
> 064181
> >
> 032&amp;sdata=A9hAX4oTyJPzc4J3y3PqwNagWEqvpGolf8RE9RyYV28%3D&am
> p;reser
> > ved=0
> >
> > Yogesh Gaur (7):
> >   spi: add support for octal mode I/O data transfer
> >   spi: spi-mem: add support for octal mode I/O data transfer
> 
> 
> These two patches are already merged and is now part of linux-next[1].
> Its preferred to send patches based on top of latest linux-next so as to avoid
> resending patches that have already been picked up by the maintainer.
> 
> [1]
> commit 6b03061f882de49b83ccf44beb3a12c920a2da1b
> Author: Yogesh Narayan Gaur <yogeshnarayan.gaur@xxxxxxx>
> Date:   Mon Dec 3 08:39:06 2018 +0000
> 
>     spi: add support for octal mode I/O data transfer
> 
> commit b12a084c8729ef423089bb9a5a143eed39cd94e7
> Author: Yogesh Narayan Gaur <yogeshnarayan.gaur@xxxxxxx>
> Date:   Mon Dec 3 08:39:12 2018 +0000
> 
>     spi: spi-mem: add support for octal mode I/O data transfer
> 
> 
I have checked on repo "git://git.infradead.org/linux-mtd.git" on branch "spi-nor/next" and in that kernel version is 4.20.-rc5.
In this repo above 2 patches are not present and hence has send the patches by moving to top of this repo.

Can you please let me know the repo of linux-next and branch to use.

--
Regards
Yogesh Gaur

> Regards
> Vignesh
> 
> >   mtd: spi-nor: add opcodes for octal Read/Write commands
> >   mtd: spi-nor: add octal read flag for flash mt35xu512aba
> >   mtd: m25p80: add support of octal mode I/O transfer
> >   spi: nxp-fspi: add octal mode flag bit for octal support
> >   arm64: dts: lx2160a: update fspi node
> >
> > Changes for v6:
> > - Correct S-o-b tag with full author name as 'Yogesh Narayan Gaur'.
> > - Rebase on top of v4.20-rc5.
> > Changes for v5:
> > - Modified string 'octo' as 'octal' in all patches.
> > Changes for v4:
> > - Rebase on top of v4.20-rc2.
> > - Modify octo entries enum value in spi.h.
> > Changes for v3:
> > - Add octo mode support in spi_setup().
> > - Rename all patches with 'octal' string modified as 'octo'.
> > Changes for v2:
> > - Incorporated review comments of Boris and Vignesh.
> >
> > Yogesh Gaur (7):
> >   spi: add support for octal mode I/O data transfer
> >   spi: spi-mem: add support for octal mode I/O data transfer
> >   mtd: spi-nor: add opcodes for octal Read/Write commands
> >   mtd: spi-nor: add octal read flag for flash mt35xu512aba
> >   mtd: m25p80: add support of octal mode I/O transfer
> >   spi: nxp-fspi: add octal mode flag bit for octal support
> >   arm64: dts: lx2160a: update fspi node
> >
> >  arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts |  4 ++++
> >  drivers/mtd/devices/m25p80.c                      |  9 ++++++++-
> >  drivers/mtd/spi-nor/spi-nor.c                     | 19 ++++++++++++++++---
> >  drivers/spi/spi-mem.c                             |  9 ++++++++-
> >  drivers/spi/spi-nxp-fspi.c                        |  4 ++--
> >  drivers/spi/spi.c                                 | 12 ++++++++++--
> >  include/linux/mtd/spi-nor.h                       | 16 ++++++++++++----
> >  include/linux/spi/spi.h                           |  4 +++-
> >  8 files changed, 63 insertions(+), 14 deletions(-)
> >
> 
> --
> Regards
> Vignesh