On Thu, Dec 13, 2018 at 10:04:56AM +0100, Jerome Brunet wrote: > On Thu, 2018-12-13 at 16:39 +0800, Sunny Luo wrote: > > > > writel_bits_relaxed(BIT(24), BIT(24), spicc->base + SPICC_TESTREG); > > > > + meson_spicc_oen_enable(spicc); > > + > Any specific reason for doing this in prepare_message() ? It looks like > something that could/should be done during the probe ? If it's for power management then there should be a matching disable in unprepare_message() (or this should just be in the runtime PM code, though it's possible there's stuff that's only needed while actually doing transfers in which case this could make sense). Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message, helping ensure it won't be missed by people scrolling through the irrelevant quoted material.
Attachment:
signature.asc
Description: PGP signature
