RE: [PATCH 2/5] spi: imx: mx51-ecspi: Move some initialisation to prepare_message hook.

[Robin Gong <yibin.gong@xxxxxxx>]

> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Sent: 2018年11月23日 3:54
> To: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Marek Vasut <marex@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>;
> kernel@xxxxxxxxxxxxxx; linux-spi@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/5] spi: imx: mx51-ecspi: Move some initialisation to
> prepare_message hook.
> 
> On Mon, Nov 19, 2018 at 09:18:16PM +0100, Uwe Kleine-König wrote:
> > The relevant difference between prepare_message and config is that the
> > former is run before the CS signal is asserted. So the polarity of the
> > CLK line must be configured in prepare_message as an edge generated by
> > config might already result in a latch of the MOSI line.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> This patch doesn't apply as is to v4.20-rc1 because it conflicts with patches by
> Robin Gong. The conflict isn't hard to resolve, but please tell me if I should
> resend anyhow.
Please resend then I can have a quick test for your patch set.
> 
> Best regards
> Uwe
> 
> --
> Pengutronix e.K.                           | Uwe Kleine-König
> |
> Industrial Linux Solutions                 |
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> pengutronix.de%2F&amp;data=02%7C01%7Cyibin.gong%40nxp.com%7C69dfa
> 9433b684585dc5208d650b43b6d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7
> C0%7C0%7C636785132352324583&amp;sdata=VDUqNhUdJcHhbgQ%2FLvSeA
> PZn8eW%2BYxGnBSENTbEDx6I%3D&amp;reserved=0  |