Re: [PATCH 3/5] spi: imx: style fixes

[Marek Vasut <marex@xxxxxxx>]

On 11/19/2018 09:18 PM, Uwe Kleine-König wrote:
> This change fixes some random style issues that I noticed while debugging
> the driver: Remove some double spaces, use tabs for indention instead
> of spaces if possible, fix comment style.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
>  drivers/spi/spi-imx.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index c872c81d7ba1..73d4e99c4172 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -39,8 +39,8 @@
>  #define MXC_INT_TE	(1 << 1) /* Transmit FIFO empty interrupt */
>  #define MXC_INT_RDR	BIT(4) /* Receive date threshold interrupt */
>  
> -/* The maximum  bytes that a sdma BD can transfer.*/
> -#define MAX_SDMA_BD_BYTES  (1 << 15)
> +/* The maximum bytes that a sdma BD can transfer. */
> +#define MAX_SDMA_BD_BYTES (1 << 15)
>  #define MX51_ECSPI_CTRL_MAX_BURST	512
>  /* The maximum bytes that IMX53_ECSPI can transfer in slave mode.*/
>  #define MX53_MAX_TRANSFER_BYTES		512
> @@ -262,7 +262,7 @@ static bool spi_imx_can_dma(struct spi_master *master, struct spi_device *spi,
>  #define MX51_ECSPI_INT_RREN		(1 <<  3)
>  #define MX51_ECSPI_INT_RDREN		(1 <<  4)

You may as well switch this to BIT() macro ?

-- 
Best regards,
Marek Vasut