Re: [PATCH] spi: lpspi: Add Slave Mode support for LPSPI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 12, 2018 at 06:47:08AM +0000, Clark Wang wrote:

This looks fine so I'll apply it but it would have been easier to review
if it were split up a bit.  There's mechanical changes like:

> -static int lpspi_prepare_xfer_hardware(struct spi_master *master)
> +static int lpspi_prepare_xfer_hardware(struct spi_controller *controller)
>  {

...the conversion to controller...

> -	temp = fsl_lpspi->txfifosize >> 1 | (fsl_lpspi->rxfifosize >> 1) << 16;
> +	temp = fsl_lpspi->watermark >> 1 | (fsl_lpspi->watermark >> 1) << 16;

...and this renaming which could be done separately.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux