Hi, On Thu, Oct 25, 2018 at 9:40 AM Alok Chauhan <alokc@xxxxxxxxxxxxxx> wrote: > > Re-arrange existing APIs in probe function to > avoid using goto and remove redundant variables. > > Signed-off-by: Alok Chauhan <alokc@xxxxxxxxxxxxxx> > --- > drivers/spi/spi-geni-qcom.c | 49 ++++++++++++++++++++++----------------------- > 1 file changed, 24 insertions(+), 25 deletions(-) I agree that this is what Stephen was looking for in his review feedback. I personally thought it was fine the way it was but I have no objections to this. Thanks for following up. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>