Re: [spi:for-4.20 62/63] drivers/spi/spi-pxa2xx.c:1457:15: error: implicit declaration of function 'pci_match_id'; did you mean 'pci_map_sg'?

[Lubomir Rintel <lkundrak@xxxxx>]

On Fri, 2018-10-12 at 02:03 +0800, kbuild test robot wrote:
> tree:   
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-
> 4.20
> head:   44221ebae2da9daad053e383240d8aeacacaa43e
> commit: 87ae1d2d70772d661162de03e56c8d1cc5f12650 [62/63] spi: pxa2xx:
> Add devicetree support
> config: arm-imote2_defconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget 
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 87ae1d2d70772d661162de03e56c8d1cc5f12650
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.2.0 make.cross ARCH=arm 
> 
> All error/warnings (new ones prefixed by >>):
> 
>    drivers/spi/spi-pxa2xx.c: In function 'pxa2xx_spi_init_pdata':
> > > drivers/spi/spi-pxa2xx.c:1457:15: error: implicit declaration of
> > > function 'pci_match_id'; did you mean 'pci_map_sg'? [-
> > > Werror=implicit-function-declaration]
>       pcidev_id = pci_match_id(pxa2xx_spi_pci_compound_match,
>                   ^~~~~~~~~~~~
>                   pci_map_sg

Mark, this patch would fix the failure:

"[PATCH v2 02/11] PCI: Provide pci_match_id() with CONFIG_PCI=n"
<https://lore.kernel.org/lkml/20181010170936.316862-3-lkundrak@xxxxx/>

I'm wondering if it makes sense to pull this into the SPI tree as
opposed to PCI? Otherwise we'd have to #ifdef around it for now.

The patch got an Ack from Bjorn, the PCI subsystem maintainer.

Lubo


> > > drivers/spi/spi-pxa2xx.c:1457:13: warning: assignment makes
> > > pointer from integer without a cast [-Wint-conversion]
>       pcidev_id = pci_match_id(pxa2xx_spi_pci_compound_match,
>                 ^
>    cc1: some warnings being treated as errors
> 
> vim +1457 drivers/spi/spi-pxa2xx.c
> 
> 87ae1d2d7 Lubomir Rintel  2018-10-10  1438  
> a3496855d Mika Westerberg 2013-01-22  1439  static struct
> pxa2xx_spi_master *
> 0db642151 Jarkko Nikula   2015-10-
> 28  1440  pxa2xx_spi_init_pdata(struct platform_device *pdev)
> a3496855d Mika Westerberg 2013-01-22  1441  {
> a3496855d Mika Westerberg 2013-01-22  1442  	struct
> pxa2xx_spi_master *pdata;
> a3496855d Mika Westerberg 2013-01-22  1443  	struct acpi_device
> *adev;
> a3496855d Mika Westerberg 2013-01-22  1444  	struct ssp_device *ssp;
> a3496855d Mika Westerberg 2013-01-22  1445  	struct resource *res;
> 34cadd9c1 Jarkko Nikula   2015-07-30  1446  	const struct
> acpi_device_id *adev_id = NULL;
> 34cadd9c1 Jarkko Nikula   2015-07-30  1447  	const struct
> pci_device_id *pcidev_id = NULL;
> 87ae1d2d7 Lubomir Rintel  2018-10-10  1448  	const struct
> of_device_id *of_id = NULL;
> 55ef8262f Lubomir Rintel  2018-10-10  1449  	enum pxa_ssp_type type;
> a3496855d Mika Westerberg 2013-01-22  1450  
> b9f6940a4 Jarkko Nikula   2015-09-25  1451  	adev =
> ACPI_COMPANION(&pdev->dev);
> a3496855d Mika Westerberg 2013-01-22  1452  
> 87ae1d2d7 Lubomir Rintel  2018-10-10  1453  	if (pdev->dev.of_node)
> 87ae1d2d7 Lubomir Rintel  2018-10-10  1454  		of_id =
> of_match_device(pdev->dev.driver->of_match_table,
> 87ae1d2d7 Lubomir Rintel  2018-10-10  1455  				
> 	&pdev->dev);
> 87ae1d2d7 Lubomir Rintel  2018-10-10  1456  	else if
> (dev_is_pci(pdev->dev.parent))
> 34cadd9c1 Jarkko Nikula   2015-07-30 @1457  		pcidev_id =
> pci_match_id(pxa2xx_spi_pci_compound_match,
> 34cadd9c1 Jarkko Nikula   2015-07-30  1458  				
> 	 to_pci_dev(pdev->dev.parent));
> 0db642151 Jarkko Nikula   2015-10-28  1459  	else if (adev)
> 34cadd9c1 Jarkko Nikula   2015-07-30  1460  		adev_id =
> acpi_match_device(pdev->dev.driver->acpi_match_table,
> 34cadd9c1 Jarkko Nikula   2015-07-30  1461  				
> 	    &pdev->dev);
> 0db642151 Jarkko Nikula   2015-10-28  1462  	else
> 0db642151 Jarkko Nikula   2015-10-28  1463  		return NULL;
> 34cadd9c1 Jarkko Nikula   2015-07-30  1464  
> 34cadd9c1 Jarkko Nikula   2015-07-30  1465  	if (adev_id)
> 55ef8262f Lubomir Rintel  2018-10-10  1466  		type = (enum
> pxa_ssp_type)adev_id->driver_data;
> 34cadd9c1 Jarkko Nikula   2015-07-30  1467  	else if (pcidev_id)
> 55ef8262f Lubomir Rintel  2018-10-10  1468  		type = (enum
> pxa_ssp_type)pcidev_id->driver_data;
> 87ae1d2d7 Lubomir Rintel  2018-10-10  1469  	else if (of_id)
> 87ae1d2d7 Lubomir Rintel  2018-10-10  1470  		type = (enum
> pxa_ssp_type)of_id->data;
> 03fbf488c Jarkko Nikula   2015-06-04  1471  	else
> 03fbf488c Jarkko Nikula   2015-06-04  1472  		return NULL;
> 03fbf488c Jarkko Nikula   2015-06-04  1473  
> cc0ee9873 Mika Westerberg 2013-06-20  1474  	pdata =
> devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
> 9deae4592 Jingoo Han      2014-04-29  1475  	if (!pdata)
> a3496855d Mika Westerberg 2013-01-22  1476  		return NULL;
> a3496855d Mika Westerberg 2013-01-22  1477  
> a3496855d Mika Westerberg 2013-01-22  1478  	res =
> platform_get_resource(pdev, IORESOURCE_MEM, 0);
> a3496855d Mika Westerberg 2013-01-22  1479  	if (!res)
> a3496855d Mika Westerberg 2013-01-22  1480  		return NULL;
> a3496855d Mika Westerberg 2013-01-22  1481  
> a3496855d Mika Westerberg 2013-01-22  1482  	ssp = &pdata->ssp;
> a3496855d Mika Westerberg 2013-01-22  1483  
> a3496855d Mika Westerberg 2013-01-22  1484  	ssp->phys_base = res-
> >start;
> cbfd6a21b Sachin Kamat    2013-04-08  1485  	ssp->mmio_base =
> devm_ioremap_resource(&pdev->dev, res);
> cbfd6a21b Sachin Kamat    2013-04-08  1486  	if (IS_ERR(ssp-
> >mmio_base))
> 6dc81f6fc Mika Westerberg 2013-05-13  1487  		return NULL;
> a3496855d Mika Westerberg 2013-01-22  1488  
> 
> :::::: The code at line 1457 was first introduced by commit
> :::::: 34cadd9c1bcbd5ad5a1f379b013526a8046d4aed spi: pxa2xx: Add
> support for Intel Sunrisepoint
> 
> :::::: TO: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> :::::: CC: Mark Brown <broonie@xxxxxxxxxx>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source
> Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel
> Corporation