Re: [PATCH v2 3/3] spi: spidev: Fix OF tree warning logic

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Thu, Sep 20, 2018 at 9:18 PM Trent Piepho <tpiepho@xxxxxxxxxx> wrote:
> spidev will make a big fuss if a device tree node binds a device by
> using "spidev" as the node's compatible property.
>
> However, the logic for this isn't looking for "spidev" in the
> compatible, but rather checking that the device is NOT compatible with
> spidev's list of devices.
>
> This causes a false positive if a device not named "rohm,dh2228fv", etc.
> binds to spidev, even if a means other than putting "spidev" in the
> device tree was used.  E.g., the sysfs driver_override attribute.
>
> Signed-off-by: Trent Piepho <tpiepho@xxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds