Re: [PATCH 1/2] spi: Add driver_override SPI device attribute

[Trent Piepho <tpiepho@xxxxxxxxxx>]

On Wed, 2018-09-19 at 10:38 -0700, Mark Brown wrote:
> On Wed, Sep 19, 2018 at 08:38:09AM +0200, Geert Uytterhoeven wrote:
> > On Wed, Sep 19, 2018 at 12:50 AM Trent Piepho <tpiepho@xxxxxxxxxx> wrote:
> > > +       /* Attach device to new driver if it's not already attached */
> > > +       ret = device_attach(dev);
> > This is something the other buses don't do.  Hence they require the user to
> > explicitly bind the device by writing the device name to the driver's "bind"
> > file in sysfs. Looks useful to have for the other buses, too.
> 
> Or if there's a good reason to require the explicit bind then we should
> remove this from here so we're consistent between buses.  I guess send
> patches to the other buses and see what happens?

Having the automatic attach makes it far easier to use with udev.  I
can send a patch for other busses.  I hope it doesn't get rejected
with, "That would have been a good idea, but we can't change it now
because someone might care about it not attaching."  Even though no one
does.