Re: [PATCH] spi: gpio: Fix copy-and-paste error

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Linus,

On Mon, Sep 3, 2018 at 11:40 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> This fixes an embarrassing copy-and-paste error in the
> errorpath of spi_gpio_request(): we were checking the wrong
> struct member for error code right after retrieveing the
> sck GPIO.

Thanks for your patch!

> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Fixes: 9b00bc7b901ff672 ("spi: spi-gpio: Rewrite to use GPIO descriptors")
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> --- a/drivers/spi/spi-gpio.c
> +++ b/drivers/spi/spi-gpio.c
> @@ -422,7 +422,6 @@ static int spi_gpio_probe(struct platform_device *pdev)
>         spi_gpio->bitbang.master = master;
>         spi_gpio->bitbang.chipselect = spi_gpio_chipselect;
>         spi_gpio->bitbang.set_line_direction = spi_gpio_set_direction;
> -

Not really related to the actual fix...

>         if ((master_flags & (SPI_MASTER_NO_TX | SPI_MASTER_NO_RX)) == 0) {
>                 spi_gpio->bitbang.txrx_word[SPI_MODE_0] = spi_gpio_txrx_word_mode0;
>                 spi_gpio->bitbang.txrx_word[SPI_MODE_1] = spi_gpio_txrx_word_mode1;

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds