Re: [PATCH] spi: orion: cosmetics - alias long direct_access variables

[Kosta Zertsekel <zertsekel@xxxxxxxxx>]

On Mon, Aug 6, 2018 at 10:09 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>> @@ -683,6 +683,7 @@ static int orion_spi_probe(struct platform_device *pdev)
>>
>>       /* Scan all SPI devices of this controller for direct mapped devices */
>>       for_each_available_child_of_node(pdev->dev.of_node, np) {
>> +             struct orion_direct_acc *dacc;
>
> I would prefer direct_access, but it looks like this is too long to
> put the devm_ioremap on one line. But it should be enough to fix the
> odd indentation of r->start and PAGE_SIZE.

Actually, the longest possible name to put devm_ioremap on one line is
`dir_acc`.
I think `dir_acc` is readable enough to ring the `direct_access` in
the mind of a reader.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html