Re: [PATCH] spi: pl022: Add OF binding to disable DMA usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 26, 2018 at 11:04:24AM +0200, Alexander Sverdlin wrote:
> On 25/07/18 19:06, Mark Brown wrote:

> > this or if we shouldn't instead be looking at improving the driver to
> > work better in systems with limited channels, for example by only
> > claiming the channels when it's active (since it can fall back to PIO if
> > it doesn't get them).  That might be too heavyweight though, possibly

> yes, this is an option as well, but at the time we need to take this decision
> the bus scan has not yet been performed. We could scan all the devices in
> the DT and check if any of them requires DMA. This would mean, that
> probe() of the PL022 driver will include similar code to the bus scan
> that anyway will happen later just to take the decision on DMA usage.

> But I'm fine with that. If this sounds better than new boolean DT binding,
> I'll send another patch.

I'm not 100% clear I follow what you mean by bus scan here but I *think*
that sounds about right.  The channel request/release could be factored
out into helper functions to minimize duplication.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux