Re: [PATCH] spi: pl022: Remove timeout in polling mode operation

[Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>]

Hello Lars,

On 16/07/18 10:21, Lars-Peter Clausen wrote:
>> Well, if it's scheduled at all. In our case a poor task is not scheduled at all
>> for 1-2 seconds (because of other high prio tasks which are here for a reason as
>> well).
>> So from the priority PoV we can allow a task reading from MTD to wait couple of
>> seconds, but it's really strange for it to fail even though the MTD media itself
>> is not corrupted.
>> The risk increases with the number of tasks and hundreds of tasks in startup is
>> not seldom and if one has HZ=100... This 1 second timeout is prone to fail
>> in highly loaded system.
> You'd run readwriter() before checking the timeout and reset the timeout if
> it is able to make progress. Only if there was no progress you'd check the
> timeout.

I think your point is valid, but I don't feel only this improvement will be enough.
What do you think about both increasing the timeout to 60-120sec and resetting
timeout if a progress has been made?
Then I can prepare v2.

-- 
Best regards,
Alexander Sverdlin.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html