Re: [PATCH] spi: spi-s3c64xx: Fix system resume support

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On Wed, May 16, 2018 at 10:42 AM, Marek Szyprowski
<m.szyprowski@xxxxxxxxxxx> wrote:
> Since Linux v4.10 release (commit 1d9174fbc55e "PM / Runtime: Defer
> resuming of the device in pm_runtime_force_resume()"),
> pm_runtime_force_resume() function doesn't runtime resume device if it was
> not runtime active before system suspend. Thus, driver should not do any
> register access after pm_runtime_force_resume() without checking the
> runtime status of the device. To fix this issue, simply move
> s3c64xx_spi_hwinit() call to s3c64xx_spi_runtime_resume() to ensure that
> hardware is always properly initialized. This fixes Synchronous external
> abort issue on system suspend/resume cycle on newer Exynos SoCs.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> ---
> This patch is prepared on top of linux-next. I intentionally didn't add
> any CC: stable tags, because such backport requires a change in
> s3c64xx_spi_hwinit() function parameters, what is caused by the commit
> 1c75862d8e5a ("spi: spi-s3c64xx: Remove unused s3c64xx_spi_hwinit()
> function argument") in current -next patchset.

Then how about:

Cc: <stable@xxxxxxxxxxxxxxx> # 4.10.x: 1c75862d8e5a "spi: spi-s3c64xx:
Remove unused s3c64xx_spi_hwinit()
Cc: <stable@xxxxxxxxxxxxxxx> # 4.10.x

Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html