Re: [PATCH 2/2] spi: omap2-mcspi: Idle hardware during suspend and resume

[Tony Lindgren <tony@xxxxxxxxxxx>]

* kbuild test robot <lkp@xxxxxxxxx> [180427 13:08]:
> Hi Tony,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on spi/for-next]
> [also build test ERROR on v4.17-rc2 next-20180426]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Tony-Lindgren/Suspend-improvments-for-omap2-mcspi/20180427-152647
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
> config: sparc64-allyesconfig (attached as .config)
> compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=sparc64 
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers//spi/spi-omap2-mcspi.c:1515:19: error: 'omap2_mcspi_suspend_noirq' undeclared here (not in a function); did you mean 'omap2_mcspi_suspend'?
>      .suspend_noirq = omap2_mcspi_suspend_noirq,
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~
>                       omap2_mcspi_suspend
> >> drivers//spi/spi-omap2-mcspi.c:1516:18: error: 'omap2_mcspi_resume_noirq' undeclared here (not in a function); did you mean 'omap2_mcspi_suspend_noirq'?
>      .resume_noirq = omap2_mcspi_resume_noirq,
>                      ^~~~~~~~~~~~~~~~~~~~~~~~
>                      omap2_mcspi_suspend_noirq
> 
> vim +1515 drivers//spi/spi-omap2-mcspi.c
> 
>   1513	
>   1514	static const struct dev_pm_ops omap2_mcspi_pm_ops = {
> > 1515		.suspend_noirq = omap2_mcspi_suspend_noirq,
> > 1516		.resume_noirq = omap2_mcspi_resume_noirq,
>   1517		.runtime_resume	= omap_mcspi_runtime_resume,
>   1518	};
>   1519	

Thanks will fix the naming if CONFIG_SUSPEND is not set and repost.

Regards,

Tony


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html