On Thu, Apr 05, 2018 at 11:19:13AM +0200, Maxime Ripard wrote: > On Wed, Apr 04, 2018 at 02:35:14PM +0300, Sergey Suloev wrote: > > What exactly and in what way ? > You should explain, at least: > A) What is the current behaviour > B) Why that is a problem, or what problem does it cause > C) What solution you implement and why you think it's justified Right, this is key - the top level problem with most of this patch set is that it's hard to understand what the changes are intended to do or why. It's really important that people reading the changes be able to understand what's going on, especially if technical problems have been found since that tends to make people look more closely. Part of this is about splitting the changes out so that each patch does one thing (which makes it easier to understand them) and part of it is about explaining those changes clearly.
Attachment:
signature.asc
Description: PGP signature
