RE: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of platform dependency

[Madalin-cristian Bucur <madalin.bucur@xxxxxxx>]

> -----Original Message-----
> From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev-owner@xxxxxxxxxxxxxxx]
> On Behalf Of Geert Uytterhoeven
> Sent: Friday, March 16, 2018 3:52 PM
> To: Christoph Hellwig <hch@xxxxxx>; Marek Szyprowski
> <m.szyprowski@xxxxxxxxxxx>; Robin Murphy <robin.murphy@xxxxxxx>;
> Felipe Balbi <balbi@xxxxxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; James E . J . Bottomley
> <jejb@xxxxxxxxxxxxxxxxxx>; Martin K . Petersen
> <martin.petersen@xxxxxxxxxx>; Andrew Morton <akpm@linux-
> foundation.org>; Mark Brown <broonie@xxxxxxxxxx>; Liam Girdwood
> <lgirdwood@xxxxxxxxx>; Tejun Heo <tj@xxxxxxxxxx>; Herbert Xu
> <herbert@xxxxxxxxxxxxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>;
> Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>; Stefan Richter
> <stefanr@xxxxxxxxxxxxxxxxx>; Alan Tull <atull@xxxxxxxxxx>; Moritz Fischer
> <mdf@xxxxxxxxxx>; Wolfram Sang <wsa@xxxxxxxxxxxxx>; Jonathan Cameron
> <jic23@xxxxxxxxxx>; Joerg Roedel <joro@xxxxxxxxxx>; Matias Bjorling
> <mb@xxxxxxxxxxx>; Jassi Brar <jassisinghbrar@xxxxxxxxx>; Mauro Carvalho
> Chehab <mchehab@xxxxxxxxxx>; Ulf Hansson <ulf.hansson@xxxxxxxxxx>; David
> Woodhouse <dwmw2@xxxxxxxxxxxxx>; Brian Norris
> <computersforpeace@xxxxxxxxx>; Marek Vasut <marek.vasut@xxxxxxxxx>;
> Cyrille Pitchen <cyrille.pitchen@xxxxxxxxxx>; Boris Brezillon
> <boris.brezillon@xxxxxxxxxxxxxxxxxx>; Richard Weinberger <richard@xxxxxx>;
> Kalle Valo <kvalo@xxxxxxxxxxxxxx>; Ohad Ben-Cohen <ohad@xxxxxxxxxx>;
> Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>; Eric Anholt <eric@xxxxxxxxxx>;
> Stefan Wahren <stefan.wahren@xxxxxxxx>
> Cc: iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-
> scsi@xxxxxxxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx;
> linux-crypto@xxxxxxxxxxxxxxx; linux-fbdev@xxxxxxxxxxxxxxx; linux1394-
> devel@xxxxxxxxxxxxxxxxxxxxx; linux-fpga@xxxxxxxxxxxxxxx; linux-
> i2c@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; linux-block@xxxxxxxxxxxxxxx;
> linux-media@xxxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; linux-
> mtd@xxxxxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> remoteproc@xxxxxxxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx; linux-
> spi@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Subject: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of
> platform dependency
> 
> Remove dependencies on HAS_DMA where a Kconfig symbol depends on
> another
> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
> In most cases this other symbol is an architecture or platform specific
> symbol, or PCI.
> 
> Generic symbols and drivers without platform dependencies keep their
> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that
> cannot work anyway.
> 
> This simplifies the dependencies, and allows to improve compile-testing.
> 
> Notes:
>   - FSL_FMAN keeps its dependency on HAS_DMA, as it calls set_dma_ops(),
>     which does not exist if HAS_DMA=n (Do we need a dummy? The use of
>     set_dma_ops() in this driver is questionable),

Hi,

The set_dma_ops() is no longer required in the fsl/fman, I'll send a patch to remove it.

Thanks

>   - SND_SOC_LPASS_IPQ806X and SND_SOC_LPASS_PLATFORM loose their
>     dependency on HAS_DMA, as they are selected from
>     SND_SOC_APQ8016_SBC.
> 
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>
> Acked-by: Robin Murphy <robin.murphy@xxxxxxx>
> ---
> v2:
>   - Add Reviewed-by, Acked-by,
>   - Drop RFC state,
>   - Split per subsystem.
> ---
>  drivers/lightnvm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
> index 10c08982185a572f..9c03f35d9df113c6 100644
> --- a/drivers/lightnvm/Kconfig
> +++ b/drivers/lightnvm/Kconfig
> @@ -4,7 +4,7 @@
> 
>  menuconfig NVM
>  	bool "Open-Channel SSD target support"
> -	depends on BLOCK && HAS_DMA && PCI
> +	depends on BLOCK && PCI
>  	select BLK_DEV_NVME
>  	help
>  	  Say Y here to get to enable Open-channel SSDs.
> --
> 2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html