On Sun, Mar 11, 2018 at 02:33:32PM +0100, Noralf Trønnes wrote:
> Den 10.03.2018 16.51, skrev Meghana Madhyastha:
> > trace_spi_message_start(ctlr->cur_msg);
> > if (ctlr->prepare_message) {
> > + gfp_t gfp_flags = GFP_KERNEL | GFP_DMA;
> > + size_t max_transfer_size = 32000;
> What number is this?
> As Geert says, this shouldn't be in the core but in the driver callback
> bcm2835_spi_prepare_message().
No, this definitely does belong in the core - the limit should come from
the driver but if there is a limit then we shouldn't require each driver
to open code using that limit.
Attachment:
signature.asc
Description: PGP signature
