Re: [PATCH 1/5] gpio: of: Support SPI nonstandard GPIO properties

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Thu, Jan 4, 2018 at 10:24 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Wed, Jan 3, 2018 at 4:23 PM, Rob Herring <robh@xxxxxxxxxx> wrote:

>> Instead of the ifdef:
>>
>> if (!IS_ENABLED(CONFIG_SPI_MASTER))
>>   return ERR_PTR(-ENOENT);
>>
>> Or merge the condition with the if below.
>
> I was consciously exploting the fact the CONFIG_SPI_MASTER is bool,
> but I guess that can be fragile if someone decides to modularize it so, OK.

Just a side note, we have IS_BUILTIN() for booleans.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html