Re: [PATCH 4/5] spi: spi-gpio: Make optional chipselect handling more explicit

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Jan 3, 2018 at 9:21 AM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

> Hmm, having two indicators for the same feature (spi_gpio->has_cs == true and
> spi_gpio->cs_gpios[0] = NULL), and the need to keep them in sync in the
> future, also complicates things.

The patch does not do this.

It removes the latter and adds the former. That is why it removes the
assignment of NULL to cs_gpios[0].

>> When there is no chip select connected, we don't even allocate a
>> placeholder for the GPIO descriptor.
>
> That's good, although it may have no effect on actual memory consumption
> due to slab granularity.

No idea, I'm not doing it to save memory anyways.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html