RE: [PATCH 1/2] spi: sh-msiof: Add compatible strings for r8a774[35]

[Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>]

Hello Geert,

Thank you for getting back to me.

> -----Original Message-----
> From: geert.uytterhoeven@xxxxxxxxx [mailto:geert.uytterhoeven@xxxxxxxxx] On Behalf Of Geert Uytterhoeven
> Sent: 25 September 2017 12:22
> To: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; linux-spi
> <linux-spi@xxxxxxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; Linux-Renesas <linux-renesas-soc@xxxxxxxxxxxxxxx>; Chris Paterson
> <Chris.Paterson2@xxxxxxxxxxx>; Biju Das <biju.das@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH 1/2] spi: sh-msiof: Add compatible strings for r8a774[35]
>
> Hi Fabrizio,
>
> On Mon, Sep 25, 2017 at 10:54 AM, Fabrizio Castro
> <fabrizio.castro@xxxxxxxxxxxxxx> wrote:
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
>
> This patch is not needed...
>
> > ---
> >  drivers/spi/spi-sh-msiof.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
> > index 0eb1e95..0080844 100644
> > --- a/drivers/spi/spi-sh-msiof.c
> > +++ b/drivers/spi/spi-sh-msiof.c
> > @@ -1021,6 +1021,8 @@ static const struct sh_msiof_chipdata rcar_gen3_data = {
> >
> >  static const struct of_device_id sh_msiof_match[] = {
> >         { .compatible = "renesas,sh-mobile-msiof", .data = &sh_data },
> > +       { .compatible = "renesas,msiof-r8a7743",   .data = &rcar_gen2_data },
> > +       { .compatible = "renesas,msiof-r8a7745",   .data = &rcar_gen2_data },
> >         { .compatible = "renesas,msiof-r8a7790",   .data = &rcar_gen2_data },
> >         { .compatible = "renesas,msiof-r8a7791",   .data = &rcar_gen2_data },
> >         { .compatible = "renesas,msiof-r8a7792",   .data = &rcar_gen2_data },
>
> ... as the driver already matches against the family-specific compatible value
> below:
>
>         { .compatible = "renesas,rcar-gen2-msiof", .data = &rcar_gen2_data },

We suspected this was the case, but we weren't sure.
I apologize for wasting your time.

Cheers,
Fabrizio

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
��.n��������+%������w��{.n�����{����)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥