On Fri, Aug 11, 2017 at 04:11:51PM +0200, Javier Martinez Canillas wrote: > On 08/11/2017 10:14 AM, Lukas Wunner wrote: > > The reason I came across this issue is that module autoloading fails for > > drivers/gpio/gpio-74x164.c as it only declares an "of" MODULE_DEVICE_TABLE. > > I was going to upstream a GPIO and an IIO driver, both SPI-based, and was > > wondering what the current best practice is: Should I only declare an > > "of" MODULE_DEVICE_TABLE or should I also provide an "spi" > > MODULE_DEVICE_TABLE? > That's a question for Mark Brown. My opinion (since I'm not a maintainer) is > that you should add a SPI device ID table and export it as spi:<foo> aliases > until this is properly fixed. Declare both. Apart from anything else not all the world is DT. > The correct way to fix this is to move this into the device model instead of > all subsystem types duplicating the same uevent logic and requiring a table > per each firmware interface. But that's a much bigger task... Yes.
Attachment:
signature.asc
Description: PGP signature
