Re: [RFC PATCH v2 00/12] spi: moving to struct gpio_desc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 29, 2017 at 4:15 PM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Fri, Jul 28, 2017 at 1:03 AM, Chris Packham
> <chris.packham@xxxxxxxxxxxxxxxxxxx> wrote:

> I briefly looked at the code, first 6 patches for my taste could be
> submitted w/o RFC tag.
> One comment to them though, better to use u32 instead of unsigned int
> when operate with 32-bit registers.

>> H Hartley Sweeten (6):
>>   spi: spi-ep93xx: use 32-bit read/write for all registers
>>   spi: spi-ep93xx: add spi master prepare_transfer_hardware()
>>   spi: spi-ep93xx: absorb the interrupt enable/disable helpers
>>   spi: spi-ep93xx: pass the spi_master pointer around
>>   spi: spi-ep93xx: remove private data 'current_msg'
>>   spi: spi-ep93xx: use the default master transfer queueing mechanism

So, after addressing above feel free to add my

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

to patches 1-6.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux