Re: [PATCH v1] spi: pxa2xx: Don't touch CS pin until we have a transfer pending

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Thu, Jul 27, 2017 at 06:49:33PM +0300, Andy Shevchenko wrote:
> GPIO descriptors, when being requested, may configure pin at the same
> time. In case of SPI chip select we shouldn't do any assumptions of the
> state of pin since we don't know yet what chip is connected there and if
> it uses high or low active state. So, leave the state of pin as is until
> transfer will start.
> 
> Fixes: 99f499cd6504 ("spi: pxa2xx: Add support for GPIO descriptor chip selects")
> Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Yes, I think this is the right thing to do,

Acked-by: Mika Westeberg <mika.westerberg@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html