Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka <jan.kiszka@xxxxxx> wrote:
> From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>
> Avoid hogging chip select GPIOs just because they are listed for the
> master. They might be mulitplexed and, if no slave device is attached,
> used for different purposes. Moreover, this strategy avoids having to
> allocate a cs_gpiods structure.
>
> Tested on the IOT2000 where the second SPI bus is connected to an
> Arduino-compatible connector and multiplexed between SPI, GPIO and PWM
> usage.

Sorry for late reply, this patch makes impossible to use GPIO
descriptors. Now it's broken in two ways as I can see.
I fixed one, and is right now hunting another problem.

P.S. Perhaps no need to revert, just heads up.

(That's why would be better to have GPIO descriptors everywhere in
this driver and tested)

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html