On 07/19/2017 03:42 AM, Fabio Estevam wrote: > Hi Vladimir, > > On Tue, Jul 18, 2017 at 9:39 PM, Vladimir Zapolskiy <vz@xxxxxxxxx> wrote: > >> FWIW I tested on DT-only i.MX31, the change works acceptable. > > MX31 has an issue with native chip select as far as I remember. Please > check DSPhl22960 from the chip errata: > http://www.nxp.com/docs/en/errata/MCIMX31CE.pdf Oh, it's unpleasant, I didn't know or experience the issue, thank you for information. I can definitely tell that a) my hardware (Logitech i.MX31 Litekit) does not allow to use GPIOs instead of native chip selects for two SPI devices on board: Atmel AT93C66A EEPROM on CSPI1 pads selected by CS2, Freescale MC13783 PMIC on CSPI2 pads selected by CS0. There is no option to mux CSPI1_SS2 or CSPI2_SS0 pad to GPIOs, so some kind of native chip select support is needed for legacy hardware, even if it is exposed to the errata item, b) MC13783 PMIC on CS0 works fine with Greg's change, c) actually there is no AT93C66A driver for better testing, but I do experience issues with the native CS2, however as I said in another email it is not related to Greg's change. By the way I'm going to unrestrict DMA support on i.MX31, due to my loose tests (only to/from MC13783) DMA transfers seem to work properly. -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html