Re: [PATCH v1] spi: mxs: implement runtime pm

[Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>]

Hello Lucas,

On Thu, Apr 27, 2017 at 10:49:09AM +0200, Lucas Stach wrote:
> > +static const struct dev_pm_ops mxs_spi_pm = {
> > +	SET_RUNTIME_PM_OPS(mxs_spi_runtime_suspend,
> > +			   mxs_spi_runtime_resume, NULL)
> > +	SET_SYSTEM_SLEEP_PM_OPS(mxs_spi_suspend, mxs_spi_resume)
> > +};
> 
> This would be UNIVERSAL_DEV_PM_OPS, but it bears the question if your
> suspend callback is really prepared to be used a system suspend
> callback. See the comment above the definition of the
> UNIVERSAL_DEV_PM_OPS macro.

that doesn't apply here as mxs_spi_runtime_suspend != mxs_spi_suspend.

/me gives a cup of coffee to Lucas
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html